Remove spurious dependencies of test-runner.
#4427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked a couple of test dependencies as such in `project/Deps.scala`. The rest of this pull request fixes some typos; the only change to the actual code is in `project/Build.scala`, where the spelling of the names of two private methods - `setDepenency` and `setDepenencyForCurrentBinVersion` - was corrected.
ekrich
suggested changes
Jul 29, 2025
docs/changelog/0.5.x/0.5.0-RC1.md
Outdated
| @@ -570,7 +570,7 @@ Big thanks to everybody who contributed to this release or reported an issue! | |||
| - Implement java.net DatagramSocket and DatagramPacket | |||
| [\#3614](https://github.com/scala-native/scala-native/pull/3614) | |||
| ([RustedBones](https://github.com/RustedBones)) | |||
| - Fix #3657: Remove a number of java.net defects | |||
There was a problem hiding this comment.
This one might be okay as I think it matches the PR and the English is ok.
docs/changelog/0.5.x/0.5.0.md
Outdated
| @@ -597,7 +597,7 @@ Big thanks to everybody who contributed to this release or reported an issue! | |||
| - Implement java.net DatagramSocket and DatagramPacket | |||
| [\#3614](https://github.com/scala-native/scala-native/pull/3614) | |||
| ([RustedBones](https://github.com/RustedBones)) | |||
| - Fix #3657: Remove a number of java.net defects | |||
docs/user/interop.md
Outdated
| @@ -177,7 +177,7 @@ name of field. | |||
| `int ScalaNativeInit(void);` function is special exported | |||
| function that needs to be called before invoking any code defined in | |||
| Scala Native. It returns `0` on successful initialization | |||
| and non-zero value in the otherwise. | |||
| and non-zero value otherwise. | |||
There was a problem hiding this comment.
Suggested change
| and non-zero value otherwise. | |
| and a non-zero value otherwise. |
| @@ -57,7 +57,7 @@ private[zip] object ZipByteConversions { | |||
| * may be available. | |||
| * | |||
| * Scala Native currently (2024-03) uses Unicode version 13.0. | |||
| * Unicode 15.1 was released in September, 2023. | |||
There was a problem hiding this comment.
I think "in" is ok for a month but "on" is certainly correct for an exact day.
Marked a couple of test dependencies as such in `project/Deps.scala`. The rest of this pull request fixes some typos; the only change to the actual code is in `project/Build.scala`, where the spelling of the names of two private methods - `setDepenency` and `setDepenencyForCurrentBinVersion` - was corrected.
I ran Code Inspection in IntelliJ IDEA ;)
You are right on all of them! |
WojciechMazur
approved these changes
Jul 31, 2025
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked a couple of test dependencies as such in
project/Deps.scala.The rest of this pull request fixes some typos; the only change to the actual code is in
project/Build.scala, where the spelling of the names of two private methods -setDepenencyandsetDepenencyForCurrentBinVersion- was corrected.