Skip to content

Backport "Fix unreachable warning in deeply nested sealed hierarchy" to LTS #20727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2024
Merged

Backport "Fix unreachable warning in deeply nested sealed hierarchy" to LTS #20727

merged 4 commits into from
Jun 22, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #18706 to the LTS branch.

PR submitted by the release tooling.
[skip ci]

dwijnand added 4 commits June 21, 2024 19:59
@dwijnand @WojciechMazur
Vulpix: Remove unused logStackTrace & downstream usages
1af9965 
[Cherry-picked 9c92162]
@dwijnand @WojciechMazur
Vulpix: Allow warn tests to have no warnings
1877e64 
[Cherry-picked b843332]
@dwijnand @WojciechMazur
Vulpix: Skip empty lines
3cee254 
[Cherry-picked 372e485]
@dwijnand @WojciechMazur
Fix unreachable warning in deeply nested sealed hierarchy
9cd5fc2 
Without applying we were constructing the type Jacket#Body, instead of
Jacket[?]#Body, which lead down to an incorrect isSubSpace calculation
and thus an unreachable warning.

[Cherry-picked 9460b7d]
Base automatically changed from lts-18725 to lts-3.3 June 22, 2024 10:17
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-18723.

Reference

@WojciechMazur WojciechMazur merged commit 3a06a2f into lts-3.3 Jun 22, 2024
@WojciechMazur WojciechMazur deleted the lts-18706 branch June 22, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WojciechMazur @dwijnand