Skip to content

Deprecation warnings for old syntax: _ type wildcards #18813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Deprecation warnings for old syntax: _ type wildcards #18813

merged 1 commit into from
Nov 14, 2023

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Nov 1, 2023 •
edited
Loading

Based on #18887
First part of #18869

  • In 3.4 we emit the deprecation warning and enable the patch with -rewrite.
  • In future we emit we make this syntax an error
//> using options -source future
def f: F[_] = ??? // error
//> using options -rewrite -source 3.4-migration
- def f: F[_] = ???
+ def f: F[?] = ???

@nicolasstucki nicolasstucki force-pushed the improve-migration-warning-for-type-wilcard-syntax branch 3 times, most recently from 6ca9de0 to a6d5ddd Compare November 1, 2023 15:16
@nicolasstucki nicolasstucki marked this pull request as ready for review November 2, 2023 12:51
@nicolasstucki nicolasstucki requested a review from odersky November 2, 2023 14:08
@nicolasstucki nicolasstucki mentioned this pull request Nov 6, 2023
Closed
@nicolasstucki nicolasstucki removed the request for review from odersky November 7, 2023 09:38
@nicolasstucki nicolasstucki force-pushed the improve-migration-warning-for-type-wilcard-syntax branch from a6d5ddd to 7f26941 Compare November 7, 2023 09:40
@nicolasstucki nicolasstucki changed the title Disallow _ for wildcard arguments of types and use ? in future Deprecation warnings for old syntax: _ type wildcards Nov 7, 2023
@nicolasstucki nicolasstucki force-pushed the improve-migration-warning-for-type-wilcard-syntax branch from 7f26941 to b7d3167 Compare November 7, 2023 09:47
@nicolasstucki

This comment was marked as outdated.

Sign in to view
@nicolasstucki nicolasstucki added this to the 3.4.0 milestone Nov 7, 2023
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Nov 8, 2023
@nicolasstucki nicolasstucki force-pushed the improve-migration-warning-for-type-wilcard-syntax branch 6 times, most recently from 168e47a to 8063875 Compare November 13, 2023 09:09
@nicolasstucki
Deprecation warnings for old syntax: _ type wildcards
b822bd0 
* In `3.4` we emit the deprecation warning and enable the
  patch with `-rewrite`.
* In `future` we emit we make this syntax an error
@nicolasstucki nicolasstucki force-pushed the improve-migration-warning-for-type-wilcard-syntax branch from 8063875 to b822bd0 Compare November 13, 2023 10:27
@nicolasstucki nicolasstucki merged commit e3af2de into scala:main Nov 14, 2023
@nicolasstucki nicolasstucki deleted the improve-migration-warning-for-type-wilcard-syntax branch November 14, 2023 09:57
This was referenced Dec 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
@saeltz saeltz mentioned this pull request Mar 15, 2024
Closed
@Lewisj190 Lewisj190 mentioned this pull request Dec 31, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

Assignees

@dwijnand dwijnand

Labels
release-notes Should be mentioned in the release notes
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @dwijnand @odersky