Skip to content

Conversation

tstenner
Copy link
Collaborator

@mgrivich
Copy link
Contributor

The new method inlet_connection::set_protocols has an error. It as the parameter const stream_info_impl &info, but refers to host_info_ in the method. Every host_info_ in set_protocols needs to be changed to info.

Other than that, I tested the pull request and it works.

@tstenner
Copy link
Collaborator Author

Thanks, fixed it.

@cboulay
Copy link
Collaborator

cboulay commented May 21, 2023

I didn't check that the issue is fixed because Matthew already did that.
Code quality is good and CI workflows are passing. Actually, I haven't seen all the CI workflows succeed in a long time so this is good news.

I'm satisfied. Merge at your leisure.

@tstenner tstenner merged commit a6f3175 into sccn:master May 22, 2023
@tstenner tstenner deleted the timerecover branch May 26, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants