Load log settings before all other settings. #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the log settings last causes heaps of INFO messages to be displayed by lsl::get_local_interfaces() even if the user has set log level to -3. Changing the order causes less ui clutter and respects the users choices.
cboulay
reviewed
Aug 16, 2022
src/api_config.cpp
Outdated
| } else | ||
| loguru::g_stderr_verbosity = log_level; | ||
|
|
||
| // log config filename only after setting the verbosity level |
There was a problem hiding this comment.
This log statement should remain at the end. We should only see "Configuration loaded ..." after we've finished parsing the loaded config.
|
Thanks for the PR. Don't worry about the ubuntu-18.04 or macOS-latest build failures. I ask that you address the one comment I left inline then this looks good to merge. |
cboulay
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the log settings last causes heaps of INFO messages to be
displayed by lsl::get_local_interfaces() even if the user has set log level to -3.
Changing the order causes less ui clutter and respects the users choices.