[2.x] Implement worker + forked test #8170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sends JSON-RPC over stdin as opposed to using ObjectStream over socket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See https://eed3si9n.com/rfc-4-persistent-worker/ for the general motivation. We want to eventually move out tests out of the sbt process, but we also don't want to lose JIT performance.
Solution
This re-implements forked test on top of the Java worker CLI, using JSON-RPC over stdin/stdout as the communication mechanism instead of using the object stream on socket. For now, it's functionally same as sbt 1.x's forked test.
Later on, we can keep the worker process running, so we can keep the classloader warm.