Skip to content

[1.x] Add settings key to surface Consistent Analysis Reproducible flag #7910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[1.x] Add settings key to surface Consistent Analysis Reproducible flag #7910

wants to merge 2 commits into from

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 25, 2024 •
edited
Loading

This PR adds a new sbt settings key enableReproducibleCompileAnalysis for Consistent Analysis's reproducible flag, added in sbt/zinc#1479.

The semantic of enableReproducibleCompileAnalysis is as follows. If the underlying analysis format is not Consistent Analysis, the settings key does nothing. Otherwise, its value is passed as reproducible flag for Consistent Analysis, for which reproducible = true ensures binary reproducible analysis output, at the expense of wiping timestamp information (and therefore less accurate zinc invalidation).

The default value of enableReproducibleCompileAnalysis is set to false, following recommendation from ephemerist in sbt/zinc#1496 (comment).

@Friendseeker Friendseeker marked this pull request as draft November 25, 2024 00:52
@Friendseeker Friendseeker changed the title [1.x] Add settings key to surface Consistent Analysis Reproducible flag & Fix CI [1.x] Add settings key to surface Consistent Analysis Reproducible flag Nov 25, 2024
@Friendseeker
Copy link
Member Author 

[error] /home/runner/work/sbt/sbt/main/src/main/scala/sbt/internal/AnalysisUtil.scala:31:28: overloaded method value staticCachedStore with alternatives:
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean,useConsistent: Boolean,mappers: xsbti.compile.analysis.ReadWriteMappers,sort: Boolean,parallelism: Int)xsbti.compile.AnalysisStore <and>
[error]   (analysisFile: java.nio.file.Path,useTextAnalysis: Boolean)xsbti.compile.AnalysisStore
[error]  cannot be applied to (analysisFile: java.nio.file.Path, useTextAnalysis: Boolean, useConsistent: Boolean, mappers: xsbti.compile.analysis.ReadWriteMappers, reproducible: Boolean, parallelism: Int)
[error]     MixedAnalyzingCompiler.staticCachedStore(

Guess we need to make a new Zinc release?

This was referenced Nov 25, 2024
Merged
Merged
@Friendseeker
Copy link
Member Author

Now after a few weeks I am having some second thoughts. Should sbt just be opinionated and not surface the key to user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Friendseeker