Skip to content

[1.x] Stop background jobs when pressing ctrl-c #7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2024
Merged

[1.x] Stop background jobs when pressing ctrl-c #7916

merged 2 commits into from
Nov 28, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 26, 2024 •
edited
Loading

Implements #7914 (comment)

In case of run we should forward cancellation to cancelling the bgRun job.

Tested via a local sbt build, using reproduction from #6346.

Supersedes #7914

Closes #6346
Closes #6242
Closes typelevel/cats-effect#2251

@Friendseeker Friendseeker changed the title [1.x] Shutdown background jobs when pressing ctrl+c [1.x] Stop background jobs when pressing ctrl+c Nov 26, 2024
@Friendseeker Friendseeker force-pushed the ctrl-c-background-task branch from db0875a to 3b45f3b Compare November 27, 2024 07:40
@Friendseeker Friendseeker changed the title [1.x] Stop background jobs when pressing ctrl+c [1.x] Stop background jobs when pressing ctrl-c Nov 27, 2024
@Friendseeker Friendseeker force-pushed the ctrl-c-background-task branch 2 times, most recently from b1c6366 to fd702c4 Compare November 27, 2024 08:21
eed3si9n
eed3si9n reviewed Nov 27, 2024
View reviewed changes
@Friendseeker Friendseeker force-pushed the ctrl-c-background-task branch from fd702c4 to a348a24 Compare November 27, 2024 09:26
@Friendseeker
Add boolean flag isAutoCancel
b49fe9d 
Address PR feedback from Eugene
@Friendseeker Friendseeker force-pushed the ctrl-c-background-task branch from a348a24 to b49fe9d Compare November 27, 2024 09:30
@Friendseeker Friendseeker mentioned this pull request Nov 27, 2024
Merged
eed3si9n
eed3si9n approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit f03ff1f into sbt:1.10.x Nov 28, 2024
10 checks passed
@Friendseeker Friendseeker mentioned this pull request Nov 28, 2024
Closed
@Friendseeker Friendseeker deleted the ctrl-c-background-task branch November 28, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Friendseeker @eed3si9n