Skip to content

[1.x] Synchronize java.awt.Desktop.browse() #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Nov 22, 2024

Issue

java.awt.Desktop.browse() is not thread safe. (At least on Windows).

Fix

Add synchronized

Fixes #7828. Confirmed the fix via publishing sbt locally & running dependencyBrowseTree against that sbt build.

@Friendseeker Friendseeker changed the title [1.x] Synchronize for java.awt.Desktop.browse() [1.x] Synchronize java.awt.Desktop.browse() Nov 22, 2024
@Friendseeker Friendseeker assigned adpi2 and unassigned adpi2 Nov 22, 2024
@Friendseeker Friendseeker requested a review from adpi2 November 22, 2024 01:32
@eed3si9n eed3si9n merged commit 0ec6424 into sbt:1.10.x Nov 22, 2024
10 checks passed
@Friendseeker Friendseeker deleted the sbt-7828 branch November 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.x] [Windows] dependencyBrowseTree & dependencyBrowseGraph crashes
3 participants