-
Notifications
You must be signed in to change notification settings - Fork 951
fix/support-ostype-linux-sbtn #7895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Androz2091 Could you sign the Scala CLA plz? - https://www.lightbend.com/contribute/cla/scala |
Thanks for the contribution, Simon! sbt on Linux currently has some quality control issues due to maintainers not using Linux and any improvement on Linux side is very welcomed! |
I wonder if we still needs the Scala CLA job, now the project is no longer affiliated with Akka (formerly Lightbend)
|
The checker is hosted by lightbend.com, but Scala CLA transfers the copyright and patents explicitly to EPFL among other things:
See https://www.scala-lang.org/news/2023/08/25/sbt-license-transfer.html. Technically, by the design of GitHub terms of service section D-6 https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license, when you send a pull request, the same licensing terms apply i.e. Apache v2 license:
Scala CLA makes a stronger claim since the copyright is transferred over. This allows the copyright owners to change the licensing terms (sbt has in the past), and the copyright owner would have legal standing if we need to sue someone for licensing violation I think. |
Thank you for your feedback. I'm having some troubles signing the Scala CLA. When clicking "Sign the agreement using your github account", it redirects me to GitHub, then I click "authorize" and gets redirected forever to "https://github.com/login/oauth/authorize?client_id=f26f1ad52ffd85411f9c&state=&scope=" with a different state everytime. Until I get ratelimited by GitHub for approx ~1h. I tried different browsers, to clear the oauth2 authorization from the security settings, even on my phone. Can you reproduce the issue, do you want me to report it somehow and get feedback from lightbend? |
@SethTisue Could we get help on this plz? 🙏🏼 |
Eugene do you by chance have a PDF version of CLA form as a former Akka employee?
|
I'm not sure if I downloaded CLA pdf. |
Hello, I sent them an email last week and they replied today that the URL is no longer https://www.lightbend.com/contribute/cla/scala/sign but https://contribute.akka.io/contribute/cla/scala. I signed the CLA there, can you confirm it is working? Thank you |
Yay! It works now! Would you like to retry rebase the branch against latest 1.10.x commit and force push to rerun the CIs? |
@adpi2 thank you for merging ^^ @Friendseeker I've just seen your message, do I still need to do something following the merge? |
No. There's nothing that needs to be done on your side. I guess Adrien manually triggered CI so that served the same purpose. Thanks for the contribution! |
Hello,
This is an attempt of fix for #7894.