Skip to content

[1.x] Return exit code 1 when client crashes & add smoke test for client #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2024
Merged

[1.x] Return exit code 1 when client crashes & add smoke test for client #7854

merged 2 commits into from
Nov 3, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 31, 2024 •
edited
Loading

Closes #7852
Closes #7853

With the change, CI Job 7 now fails when it produces a nonfunctional native image

[info] Welcome to the build for sbt.
java.lang.NoClassDefFoundError: Could not initialize class org.scalasbt.ipcsocket.JNIUnixDomainSocketLibraryProvider
	at org.scalasbt.ipcsocket.UnixDomainSocketLibraryProvider.get(UnixDomainSocketLibraryProvider.java:26)
	at org.scalasbt.ipcsocket.UnixDomainSocket.<init>(UnixDomainSocket.java:50)
	at sbt.protocol.ClientSocket$.localSocket(ClientSocket.scala:47)
	at sbt.protocol.ClientSocket$.socket(ClientSocket.scala:39)
	at sbt.internal.client.NetworkClient.mkSocket(NetworkClient.scala:147)
	at sbt.internal.client.NetworkClient.connect$1(NetworkClient.scala:196)
	at sbt.internal.client.NetworkClient.connectOrStartServerAndConnect(NetworkClient.scala:216)
	at sbt.internal.client.NetworkClient.init(NetworkClient.scala:226)
	at sbt.internal.client.NetworkClient.connect(NetworkClient.scala:764)
	at sbt.internal.client.NetworkClient$.clientImpl(NetworkClient.scala:1196)
	at sbt.internal.client.NetworkClient$.client(NetworkClient.scala:1187)
	at sbt.internal.client.NetworkClient$.$anonfun$main$4(NetworkClient.scala:1250)
	at scala.runtime.java8.JFunction0$mcI$sp.apply(JFunction0$mcI$sp.java:23)
	at sbt.internal.util.Terminal$.withStreams(Terminal.scala:431)
	at sbt.internal.client.NetworkClient$.main(NetworkClient.scala:1248)
	at sbt.internal.client.NetworkClient.main(NetworkClient.scala)
	at sbt.client.Client.main(Client.java:20)
	at java.base@23.0.1/java.lang.invoke.LambdaForm$DMH/sa346b79c.invokeStaticInit(LambdaForm$DMH)

Error: Process completed with exit code 1.

@Friendseeker Friendseeker force-pushed the return-1-when-failed branch 2 times, most recently from ef54cdb to 9e18dd3 Compare November 1, 2024 03:05
@Friendseeker Friendseeker changed the title [1.x] Return exit code 1 when Client failed [1.x] Return exit code 1 when Client failed & Smoke test for Client Nov 1, 2024
@Friendseeker Friendseeker changed the title [1.x] Return exit code 1 when Client failed & Smoke test for Client [1.x] Return exit code 1 when Client failed & add smoke test for Client Nov 1, 2024
@Friendseeker Friendseeker marked this pull request as ready for review November 1, 2024 03:33
@Friendseeker
Copy link
Member Author

Friendseeker commented Nov 1, 2024 •
edited
Loading

CI failure 7 is desired failure.

CI failure 9 is false positive. Shall rerun CI to be sure it is false positive.

@Friendseeker Friendseeker changed the title [1.x] Return exit code 1 when Client failed & add smoke test for Client [1.x] Return exit code 1 when client failed & add smoke test for client Nov 1, 2024
@Friendseeker Friendseeker changed the title [1.x] Return exit code 1 when client failed & add smoke test for client [1.x] Return exit code 1 when client crashes & add smoke test for client Nov 1, 2024
@eed3si9n
Copy link
Member

eed3si9n commented Nov 3, 2024

I suggest we merge this as-is with the failing test, and immediately build a new sbtn with the next patch number 1.10.5.

eed3si9n
eed3si9n approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit c5c094e into sbt:1.10.x Nov 3, 2024
9 of 10 checks passed
@Friendseeker Friendseeker deleted the return-1-when-failed branch November 6, 2024 22:49
@renovate renovate bot mentioned this pull request May 8, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@adpi2 adpi2 Awaiting requested review from adpi2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.x] Improve CI coverage around native build [1.x] sbt -client returns exit code 0 even if command failed
2 participants
@Friendseeker @eed3si9n