Skip to content

Deprecate useJCenter key #7822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Deprecate useJCenter key #7822

merged 1 commit into from
Oct 23, 2024

Conversation

Philippus
Copy link
Contributor

@Philippus Philippus commented Oct 23, 2024 •
edited
Loading

Applying this PR will deprecate the useJCenter key. I'm of course open for a better deprecation message proposal. Closes #7806.

@eed3si9n
Copy link
Member

@Philippus Thanks for the contribution! You might need to add @nowarn for the internal usages.

@Philippus Philippus force-pushed the deprecate-usejcenter-key branch from de95b64 to 1ba63a1 Compare October 23, 2024 05:56
adpi2
adpi2 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

eed3si9n
eed3si9n approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 5a215d0 into sbt:1.10.x Oct 23, 2024
10 checks passed
@Philippus Philippus deleted the deprecate-usejcenter-key branch October 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.x] Deprecate useJCenter key in 1.x
3 participants
@Philippus @eed3si9n @adpi2