fix: [1.x] Fixes BSP #7824
Merged
fix: [1.x] Fixes BSP #7824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** Calling -bsp with --sbt-launch-jar causes "Unrecognized option: --server". This is because --server is passed in twice since $7775 **Solution** Since the server invocation by BSP client already passes in --server, we can remove the extra --server append.
adpi2
approved these changes
Oct 24, 2024
BillyAutrey
approved these changes
Oct 24, 2024
This is a flag mostly intended for the Bash script to indicate you want to invoke sbt server. When I made sbtn the default I was concerned with creating an infinite loop as sbtn would call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7792
Problem
Calling -bsp with --sbt-launch-jar causes "Unrecognized option: --server". This is because --server is passed in twice since #7775
Solution
Since the server invocation by BSP client already passes in --server, we can remove the extra --server append.