[1.x] Let Consistent Analysis to be opt-in by default #7807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent Analysis, while having better performance on very large codebases, results in less accurate invalidation due to omission of timestamp information. For small codebases the performance improvement is negligible (<200ms per incremental compile), yet the drawback of less accurate invalidation remains.
As per discussion with Eugene, we shall make it opt-in by default instead of opt-out.
(As reference consistent analysis saves ~500ms of incremental compilation time for
scala2according to Stefan's benchmark data collected on a M2 Pro MacBook)