-
Notifications
You must be signed in to change notification settings - Fork 950
[1.x] Bump CI to JDK 21 #7760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Bump CI to JDK 21 #7760
Conversation
51eb8cf
to
9d457ef
Compare
Shall reduce the scope of it. Let's leave |
48d89ac
to
137a12a
Compare
The only outstanding scripted test is Are there any standard library methods that are not in Scala Library 2.13.11 but are added later? As a part of the test checks whether sbt properly handles methods newly added to standard library for macro expansion. |
Yes. Nothing public in the source code, but we've added things that are |
Thanks for the heads up. I guess we can do something similar to this to access these private methods. And indeed after some searching, I found one such private method: scala/scala@8077afc |
Java 21 emits Info about annotation processing, hence we need to filter out Infos so val first is the first non-info problem
2f2a65b
to
c3d6bfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work — LGTM! (though my eyeballs on this aren't worth that much compared to Eugene's and Adrien's)
I really appreciate you tackling this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Closes #7731