Skip to content

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 12, 2024

Closes #7731

@Friendseeker Friendseeker force-pushed the bump-ci-JDK-21 branch 2 times, most recently from 51eb8cf to 9d457ef Compare October 15, 2024 06:42
@Friendseeker
Copy link
Member Author

Shall reduce the scope of it. Let's leave launcher-package for later.

@Friendseeker
Copy link
Member Author

Friendseeker commented Oct 15, 2024

The only outstanding scripted test is stdlib-unfreeze, otherwise everything works for JDK 21.

Are there any standard library methods that are not in Scala Library 2.13.11 but are added later? As a part of the test checks whether sbt properly handles methods newly added to standard library for macro expansion.

@SethTisue
Copy link
Member

Are there any standard library methods that are not in Scala Library 2.13.11 but are added later?

Yes. Nothing public in the source code, but we've added things that are private[scala] or some subpackage. (And those are then public in bytecode, as expected.)

@Friendseeker
Copy link
Member Author

Yes. Nothing public in the source code, but we've added things that are private[scala] or some subpackage. (And those are then public in bytecode, as expected.)

Thanks for the heads up. I guess we can do something similar to this to access these private methods.

And indeed after some searching, I found one such private method: scala/scala@8077afc

@Friendseeker Friendseeker changed the title [2.x] Bump CI to JDK 21 [1.x] Bump CI to JDK 21 Oct 16, 2024
Java 21 emits Info about annotation processing, hence we need to filter out Infos so val first is the first non-info problem
@Friendseeker Friendseeker marked this pull request as ready for review October 16, 2024 19:12
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work — LGTM! (though my eyeballs on this aren't worth that much compared to Eugene's and Adrien's)

I really appreciate you tackling this

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@eed3si9n eed3si9n merged commit 65a87ac into sbt:1.10.x Oct 18, 2024
10 checks passed
@Friendseeker Friendseeker deleted the bump-ci-JDK-21 branch October 18, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump CI to JDK 21
3 participants