Skip to content

chore: set a default timeout for ci #7766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

nathanlao
Copy link
Contributor

@nathanlao nathanlao commented Oct 15, 2024

This is a

Chore update to close #7747

Background

Some job runs forever, set a default 25 mins to kill them

Solution

Reference: https://stackoverflow.com/questions/59073731/set-default-timeout-on-github-action-pipeline

@Friendseeker Friendseeker self-requested a review October 15, 2024 06:49
Copy link
Member

@Friendseeker Friendseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adpi2
Copy link
Member

adpi2 commented Oct 15, 2024

@nathanlao Could you please sign the CLA?

Go to https://www.lightbend.com/contribute/cla/scala and then comment on the pull request to ask for a new check.

@nathanlao
Copy link
Contributor Author

Just done signing the CLA! Thank you for taking the time to review, appreciate the chance to contribute 🙌

@adpi2 adpi2 merged commit bfb01d8 into sbt:1.10.x Oct 15, 2024
10 checks passed
@Friendseeker
Copy link
Member

@nathanlao Would you like to port the PR to develop branch, or would you like me to do it?

@nathanlao
Copy link
Contributor Author

nathanlao commented Oct 16, 2024

@nathanlao Would you like to port the PR to develop branch, or would you like me to do it?

@Friendseeker Hey, thanks for reminding! Can I submitted another pr to develop branch?

@Friendseeker
Copy link
Member

@nathanlao Would you like to port the PR to develop branch, or would you like me to do it?

@Friendseeker Hey, thanks for reminding! Can I submitted another pr to develop branch?

Of course! Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a timeout for CI jobs
3 participants