Skip to content

[1.x] feat: Use _sbt2_3 suffix #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2024
Merged

[1.x] feat: Use _sbt2_3 suffix #7671

merged 2 commits into from
Sep 15, 2024

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Sep 15, 2024 •
edited
Loading

Ref #7655

Problem

The extra attribute is a vestige from the days when sbt plugins were published on Ivy repos. On sbt 2.x, we want to switch to using _sbt2_3 suffix system.

Solution

  1. This uses normal suffix system.
  2. This drops the POM-consistent workaround POM and JAR publishing when sbt version is >1.

Note

To be clear during the milestones etc it would look more like:

[info]  published sbt-vimquit_sbt2.0.0-M1_3 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_sbt2.0.0-M1_3/0.1.1-SNAPSHOT/sbt-vimquit_sbt2.0.0-M1_3-0.1.1-SNAPSHOT.jar

not _sbt2_3 literally.

sbt:sbt-vimquit> publishM2
[info] 	published sbt-vimquit_2.12_1.0 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit_2.12_1.0-0.1.1-SNAPSHOT-javadoc.jar
[info] 	published sbt-vimquit          to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit-0.1.1-SNAPSHOT-sources.jar
[info] 	published sbt-vimquit_2.12_1.0 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit_2.12_1.0-0.1.1-SNAPSHOT.jar
[info] 	published sbt-vimquit          to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit-0.1.1-SNAPSHOT-javadoc.jar
[info] 	published sbt-vimquit          to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit-0.1.1-SNAPSHOT.jar
[info] 	published sbt-vimquit_2.12_1.0 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit_2.12_1.0-0.1.1-SNAPSHOT-sources.jar
[info] 	published sbt-vimquit_2.12_1.0 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit_2.12_1.0-0.1.1-SNAPSHOT.pom
[info] 	published sbt-vimquit          to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_2.12_1.0/0.1.1-SNAPSHOT/sbt-vimquit-0.1.1-SNAPSHOT.pom

sbt:sbt-vimquit> ++3.3.3!
sbt:sbt-vimquit> publishM2
[info] 	published sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3/0.1.1-SNAPSHOT/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3-0.1.1-SNAPSHOT.pom
[info] 	published sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3/0.1.1-SNAPSHOT/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3-0.1.1-SNAPSHOT.jar
[info] 	published sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3/0.1.1-SNAPSHOT/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3-0.1.1-SNAPSHOT-sources.jar
[info] 	published sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3 to file:/Users/xxx/.m2/repository/com/eed3si9n/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3/0.1.1-SNAPSHOT/sbt-vimquit_sbt2.0.0-alpha11-SNAPSHOT_3-0.1.1-SNAPSHOT-javadoc.jar

@eed3si9n eed3si9n force-pushed the wip/sbt-cross-publishing branch from 611b86a to b1cdcd9 Compare September 15, 2024 07:36
@eed3si9n eed3si9n marked this pull request as draft September 15, 2024 16:32
@eed3si9n
feat: Use _sbt2_3 suffix
ddeb5db 
**Problem**
The extra attribute is a vestige from the days when sbt plugins were published on Ivy repos.

**Solution**
This uses normal suffix system.
@eed3si9n
Bump the version number
5e5d007
@eed3si9n eed3si9n force-pushed the wip/sbt-cross-publishing branch from b1cdcd9 to 5e5d007 Compare September 15, 2024 19:22
@eed3si9n eed3si9n marked this pull request as ready for review September 15, 2024 19:25
@eed3si9n eed3si9n changed the title [1.x] feat: Use _sbt2_3 suffix + scripted support [1.x] feat: Use _sbt2_3 suffix Sep 15, 2024
@eed3si9n eed3si9n mentioned this pull request Sep 15, 2024
Closed
@eed3si9n eed3si9n merged commit abb410b into sbt:1.10.x Sep 15, 2024
10 checks passed
@eed3si9n eed3si9n deleted the wip/sbt-cross-publishing branch September 15, 2024 22:40
@eed3si9n eed3si9n mentioned this pull request Sep 16, 2024
Merged
adpi2
adpi2 reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thx

@renovate renovate bot mentioned this pull request Oct 8, 2024
Merged
1 task
@vasilmkd vasilmkd mentioned this pull request Aug 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 left review comments

@BillyAutrey BillyAutrey Awaiting requested review from BillyAutrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eed3si9n @adpi2