Using common Scala 2.12 version for the sbtn subproject #7605
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old, hardcoded Scala 2.12 version previously used for the sbtn project (as a kind of workaround?) was no longer supported by Scala IDE tooling. But sbtn builds just fine when using the current global setting for the Scala 2.12 version, so this commit removes the hardcoded version.
eed3si9n
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old, hardcoded Scala 2.12 version previously used for the sbtn project (as a kind of workaround?) was no longer supported by Scala IDE tooling. But sbtn builds just fine when using the current global setting for the Scala 2.12 version, so this commit removes the hardcoded version.
Metals complained, so I tried to fix it. I think the change is harmless as the "client" project contains just a Java file, which gets build anyway by Graal Native Image and not by Scala.
I've actually run the native build and verified that the resulting binary starts up. (Didn't do any further testing with it though as I don't see what could go wrong besides the build when changing that setting in the build description).