Trim spaces around k and v to tolerate extra whitespace in build.properties #7585
Conversation
sbt
Outdated
| @@ -707,6 +707,9 @@ loadConfigFile() { | |||
| } | |||
|
|
|||
| loadPropFile() { | |||
| # trim key and value so as to be more forgiving with spaces around the '=': | |||
| k=$(echo $k |sed -e 's/^\s*(.+)\s*$/\\1/g') | |||
| v=$(echo $v |sed -e 's/^\s*(.+)\s*$/\\1/g') | |||
There was a problem hiding this comment.
Just wondering if it is possible to solve this with builtin bash functionality to avoid forking a new process. E.g. something like to replace all whitespaces https://stackoverflow.com/a/19661428/810109?
There was a problem hiding this comment.
Oh I just did it that way because I saw sed was used elsewhere. Yes it looks like you can do this in plain bash. I wasn't able to get the above example working (it seems to replace all spaces, not just beginning and ending), but this approach seems to work:
str=" # 1.2.3 "
modStr="${str#"${str%%[![:space:]]*}"}"
modStr="${modStr%"${modStr##*[![:space:]]}"}"
echo "modStr is [$modStr]"
# prints '# 1.2.3'
That will work in POSIX compatible bashes.
There was a problem hiding this comment.
Ref: answer by Mateusz Piotrowski at SOF
There was a problem hiding this comment.
I pushed a new version using a function derived from the above.
|
@invadergir could you sign the Scala CLA please?
|
So sorry, I'm waiting on approval from our lawyer. I did this change while at work so they need to approve the CLA first. |
This is done. I guess the delay was because we were trying to get a corporate CLA and it seems this option doesn't exist anymore. I got approval to sign as an individual though. |
We noticed what looked like a bash error when using a build.properties that looked like this:
The error was:
I didn't realize
sbtwas a bash script, so I just added some whitespace trimming around the key and values insideloadPropFile(). Now it is more forgiving of any spaces inserted around the '='. All these test cases now work as expected with no errors:I tested that spaces in front of the key are also trimmed as well, and of course if there is a '#' at the front (even with spaces in front of it), that is still ignored.
Hope this helps.