Skip to content

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Dec 4, 2023

No description provided.

@@ -40,11 +40,13 @@ abstract class Logger extends xLogger {
def success(message: => String): Unit
def log(level: Level.Value, message: => String): Unit

def verbose(msg: Supplier[String]): Unit = debug(msg)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the Scala verbose method above just calls debug.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you send it to 1.10.x first plz?

@mkurz mkurz force-pushed the more_logger_methods branch from d9ffd32 to 2d7f087 Compare December 5, 2023 09:16
@mkurz mkurz changed the base branch from 1.9.x to 1.10.x December 5, 2023 09:16
@mkurz
Copy link
Member Author

mkurz commented Dec 5, 2023

@eed3si9n Done!

@eed3si9n eed3si9n changed the title [1.9.x] Add missing logger methods that take Java Supplier [1.10.x] Add missing logger methods that take Java Supplier Dec 5, 2023
@eed3si9n eed3si9n merged commit 2d974be into sbt:1.10.x Dec 5, 2023
@mkurz mkurz deleted the more_logger_methods branch December 5, 2023 18:33
mergify bot referenced this pull request in slick/slick Dec 14, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.7` -> `1.9.8` |

---

### Release Notes

<details>
<summary>sbt/sbt (sbt/sbt)</summary>

### [`v1.9.8`](https://togithub.com/sbt/sbt/releases/tag/v1.9.8): 1.9.8

[Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.7...v1.9.8)

#### updates

- Fixes `IO.getModifiedOrZero` on Alpine etc, by using clib `stat()`
instead of non-standard `__xstat64` abi by
[@&#8203;bratkartoffel](https://togithub.com/bratkartoffel) in
[https://github.com/sbt/io/pull/362](https://togithub.com/sbt/io/pull/362)
- As a temporary fix for JLine issue, this disables vi-style effects
inside emacs by [@&#8203;hvesalai](https://togithub.com/hvesalai) in
[https://github.com/sbt/sbt/pull/7420](https://togithub.com/sbt/sbt/pull/7420)
- Backports fix for `updateSbtClassifiers` not downloading sources
[https://github.com/sbt/sbt/pull/7437](https://togithub.com/sbt/sbt/pull/7437)
by [@&#8203;azdrojowa123](https://togithub.com/azdrojowa123)
- Backports missing logger methods that take Java Supplier
[https://github.com/sbt/sbt/pull/7447](https://togithub.com/sbt/sbt/pull/7447)
by [@&#8203;mkurz](https://togithub.com/mkurz)

**Full Changelog**: sbt/sbt@v1.9.7...v1.9.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log [here](https://developer.mend.io/github/slick/slick).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cwienberg referenced this pull request in cwienberg/spark-sorting-helpers Jan 22, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.7` -> `1.9.8` |

---

### Release Notes

<details>
<summary>sbt/sbt (sbt/sbt)</summary>

### [`v1.9.8`](https://togithub.com/sbt/sbt/releases/tag/v1.9.8): 1.9.8

[Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.7...v1.9.8)

#### updates

- Fixes `IO.getModifiedOrZero` on Alpine etc, by using clib `stat()`
instead of non-standard `__xstat64` abi by
[@&#8203;bratkartoffel](https://togithub.com/bratkartoffel) in
[https://github.com/sbt/io/pull/362](https://togithub.com/sbt/io/pull/362)
- As a temporary fix for JLine issue, this disables vi-style effects
inside emacs by [@&#8203;hvesalai](https://togithub.com/hvesalai) in
[https://github.com/sbt/sbt/pull/7420](https://togithub.com/sbt/sbt/pull/7420)
- Backports fix for `updateSbtClassifiers` not downloading sources
[https://github.com/sbt/sbt/pull/7437](https://togithub.com/sbt/sbt/pull/7437)
by [@&#8203;azdrojowa123](https://togithub.com/azdrojowa123)
- Backports missing logger methods that take Java Supplier
[https://github.com/sbt/sbt/pull/7447](https://togithub.com/sbt/sbt/pull/7447)
by [@&#8203;mkurz](https://togithub.com/mkurz)

**Full Changelog**: sbt/sbt@v1.9.7...v1.9.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants