Temporary fix for #7371 #7420
Merged
Temporary fix for #7371 #7420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix disables vi-style effects (most notably parenthesis matching) if the terminal is inside emacs. The proper fix is to update to JLine 3.24.0 where this check has been implemented in JLine proper.
|
Temporary fix for #7371 |
|
@eed3si9n can you review this also. I was hoping it would make it to what ever is the next release. This should not be merged into the branch that has the new JLine3.24.1 as that already provides the same effect. |
mergify bot
referenced
this pull request
in slick/slick
Dec 14, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.7` -> `1.9.8` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.8`](https://togithub.com/sbt/sbt/releases/tag/v1.9.8): 1.9.8 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.7...v1.9.8) #### updates - Fixes `IO.getModifiedOrZero` on Alpine etc, by using clib `stat()` instead of non-standard `__xstat64` abi by [@​bratkartoffel](https://togithub.com/bratkartoffel) in [https://github.com/sbt/io/pull/362](https://togithub.com/sbt/io/pull/362) - As a temporary fix for JLine issue, this disables vi-style effects inside emacs by [@​hvesalai](https://togithub.com/hvesalai) in [https://github.com/sbt/sbt/pull/7420](https://togithub.com/sbt/sbt/pull/7420) - Backports fix for `updateSbtClassifiers` not downloading sources [https://github.com/sbt/sbt/pull/7437](https://togithub.com/sbt/sbt/pull/7437) by [@​azdrojowa123](https://togithub.com/azdrojowa123) - Backports missing logger methods that take Java Supplier [https://github.com/sbt/sbt/pull/7447](https://togithub.com/sbt/sbt/pull/7447) by [@​mkurz](https://togithub.com/mkurz) **Full Changelog**: sbt/sbt@v1.9.7...v1.9.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slick/slick). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
cwienberg
referenced
this pull request
in cwienberg/spark-sorting-helpers
Jan 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [sbt/sbt](https://togithub.com/sbt/sbt) | patch | `1.9.7` -> `1.9.8` | --- ### Release Notes <details> <summary>sbt/sbt (sbt/sbt)</summary> ### [`v1.9.8`](https://togithub.com/sbt/sbt/releases/tag/v1.9.8): 1.9.8 [Compare Source](https://togithub.com/sbt/sbt/compare/v1.9.7...v1.9.8) #### updates - Fixes `IO.getModifiedOrZero` on Alpine etc, by using clib `stat()` instead of non-standard `__xstat64` abi by [@​bratkartoffel](https://togithub.com/bratkartoffel) in [https://github.com/sbt/io/pull/362](https://togithub.com/sbt/io/pull/362) - As a temporary fix for JLine issue, this disables vi-style effects inside emacs by [@​hvesalai](https://togithub.com/hvesalai) in [https://github.com/sbt/sbt/pull/7420](https://togithub.com/sbt/sbt/pull/7420) - Backports fix for `updateSbtClassifiers` not downloading sources [https://github.com/sbt/sbt/pull/7437](https://togithub.com/sbt/sbt/pull/7437) by [@​azdrojowa123](https://togithub.com/azdrojowa123) - Backports missing logger methods that take Java Supplier [https://github.com/sbt/sbt/pull/7447](https://togithub.com/sbt/sbt/pull/7447) by [@​mkurz](https://togithub.com/mkurz) **Full Changelog**: sbt/sbt@v1.9.7...v1.9.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cwienberg/spark-sorting-helpers). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix disables vi-style effects (most notably parenthesis matching) if the terminal is inside emacs.
The proper fix is to update to JLine 3.24.0 where this check has been implemented in JLine proper.