Make loading order alphabetical for plugins #7404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
commented
Oct 12, 2023
| @@ -216,12 +216,12 @@ object Plugins extends PluginsFunctions { | |||
| case Right(results) => | |||
| log.debug(s" :: deduced result: ${results}") | |||
| val selectedAtoms: List[Atom] = results.ordered | |||
There was a problem hiding this comment.
It does say ordered here, but evidently not ordered enough.
There was a problem hiding this comment.
I think not ordered in the Ordering sense.
**Problem** Plugins are topologically sorted, but plugins with equal weigh could modify the same key via `~=` etc, resulting in different builds depending on the artifact. **Solution** This attempts to fix that by first sorting the selected plugins by the class name before sorting it topologically.
17bf667 to
2956f16
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1875
Problem
Plugins are topologically sorted, but plugins with equal weigh could modify the same key via
~=etc, resulting in different builds depending on the artifact.Solution
This attempts to fix that by first sorting the selected plugins by the class name before sorting it topologically.