Skip to content

some trivial refactoring #7317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2023
Merged

some trivial refactoring #7317

merged 1 commit into from
Jun 25, 2023

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Jun 24, 2023

  • remove unused type params
  • use withFilter if possible
  • use collectFirst instead of collect and headOption
  • use length instead of size if Array or String
  • use foreach instead of map

@xuwei-k
some trivial refactoring
6c032b8 
- remove unused type params
- use `withFilter` if possible
- use `collectFirst` instead of `collect` and `headOption`
- use `length` instead of `size` if `Array` or `String`
- use `foreach` instead of `map`
eed3si9n
eed3si9n approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 5fc0a4c into sbt:1.9.x Jun 25, 2023
@xuwei-k xuwei-k deleted the trivial-refactoring branch June 25, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @eed3si9n