Skip to content

Fix #7297: Convert OffsetPosition to BSP range #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

Fix #7297: Convert OffsetPosition to BSP range #7298

merged 1 commit into from
Jun 14, 2023

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jun 14, 2023

Fixes #7297

An OffsetPosition contains a line and a pointer in the line. We use them to compute the startPos of the BSP range.

package example

class A {
  def foo: String = ""
}

class AA extends A {
  val foo: String = ""
//    ^^^
// overriding method foo in class A of type => String;
//  value foo needs `override' modifier
}

@adpi2 adpi2 requested a review from eed3si9n June 14, 2023 08:49
eed3si9n
eed3si9n approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adpi2!

@eed3si9n eed3si9n merged commit c6bc422 into sbt:1.9.x Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.9.x] Missing range in BSP diagnostic
2 participants
@adpi2 @eed3si9n