-
Notifications
You must be signed in to change notification settings - Fork 950
Add weaver-cats as a default test framework #7263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @kubukoz, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kubukoz!
Yea. If it keeps failing, I'll disable the test for now. |
The PR you link as a reference (#7053) adds the |
OH. yeah. I suppose the test "works" by not running any tests. Perhaps it'd be better to make the scripted tests base off a test failure instead? |
@eed3si9n would you mind approving CI once more? I expect this one to fail because the |
Confirmed locally, the test now fails. I'll push the update now. |
Inspired by #7053, let me know if I need to change anything else please :)