Skip to content

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented May 21, 2023

Inspired by #7053, let me know if I need to change anything else please :)

@lightbend-cla-validator

Hi @kubukoz,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@kubukoz kubukoz marked this pull request as ready for review May 21, 2023 14:45
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kubukoz!

@kubukoz
Copy link
Contributor Author

kubukoz commented May 21, 2023

image

This seems unrelated, perhaps worth bumping the heap size?

@eed3si9n
Copy link
Member

Yea. If it keeps failing, I'll disable the test for now.

@mzuehlke
Copy link
Contributor

mzuehlke commented May 21, 2023

The PR you link as a reference (#7053) adds the TestFramework instance to the testFrameworks key in Defaults.scala. I would have guessed that you need to do this, too.
No idea why the test works anyways.

@kubukoz
Copy link
Contributor Author

kubukoz commented May 21, 2023

OH. yeah. I suppose the test "works" by not running any tests. Perhaps it'd be better to make the scripted tests base off a test failure instead?

@kubukoz
Copy link
Contributor Author

kubukoz commented May 21, 2023

@eed3si9n would you mind approving CI once more? I expect this one to fail because the test task would succeed. I have a commit ready to go that adds the framework to the actual testFrameworks list, but would like to see this failure first

@kubukoz
Copy link
Contributor Author

kubukoz commented May 21, 2023

Confirmed locally, the test now fails. I'll push the update now.

@eed3si9n eed3si9n merged commit f8a29b7 into sbt:1.9.x May 22, 2023
@kubukoz kubukoz deleted the add-weaver branch May 22, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants