Update usage info in sbt for java-home #7171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @liang3zy22, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
My words are not clear. Could please review it and give better description? |
eed3si9n
reviewed
Mar 14, 2023
sbt
Outdated
| @@ -573,7 +573,7 @@ Usage: `basename "$0"` [options] | |||
| --sbt-version <version> use the specified version of sbt | |||
| --sbt-jar <path> use the specified jar as the sbt launcher | |||
|
|
|||
| # java version (default: java from PATH, currently $(java -version 2>&1 | grep version)) | |||
| # JAVA_HOME (this will override default JAVA_HOME) | |||
There was a problem hiding this comment.
I guess we could just remove the line completely?
There was a problem hiding this comment.
Good idea. I will update the commit to remove it.
e4bb52d to
e751581
Compare
Signed-off-by: Liang Yan <ckgppl_yan@sina.cn>
e751581 to
80fe184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the usage info for sbt argument java-home is not correct:
Actually, I think it is a copy-paste from sbt-version usage info.
So I created this PR to fix the issue.