Skip to content

Conversation

mzuehlke
Copy link
Contributor

https://github.com/olafurpg/setup-scala/releases/tag/v14 is deprecated and migration to actions/setup-java is encouraged. That action is already used in ci.yml

https://github.com/olafurpg/setup-scala/releases/tag/v14 is deprecated and migration to actions/setup-java is encouraged.
That action is already used in `ci.yml`
@lightbend-cla-validator

Hi @mzuehlke,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit a326ee1 into sbt:1.9.x Feb 21, 2023
@mzuehlke mzuehlke deleted the replace_olafurpg-setup-scala branch February 21, 2023 08:36
@mzuehlke
Copy link
Contributor Author

Should I create dedicated pull-requests to address the 1.8.x and develop branch. Or are you just merging / cherry-picking commits to the other branches.
I don't know what is best.

@eed3si9n
Copy link
Member

@mzuehlke If you could open a cherry pick PR against 1.8.x, that would be greatly appreciated.
For develop, I can make a merge commit since it should merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants