Skip to content

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Jan 21, 2023

It causes an error in (at least) fish shell: "sbt: line 174: local: `=': not a valid identifier"

It causes an error in (at least) fish shell: "sbt: line 174: local: `=': not a valid identifier"
@lightbend-cla-validator

Hi @keynmol,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@mzuehlke
Copy link
Contributor

This fixes: #7128

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistake !

@mkurz
Copy link
Member

mkurz commented Jan 21, 2023

Neeeds to be backported to 1.8.x as well.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 3f1ff98 into sbt:1.9.x Jan 21, 2023
@keynmol keynmol deleted the patch-1 branch January 21, 2023 10:53
@julienrf julienrf mentioned this pull request Jan 27, 2023
@julienrf
Copy link
Contributor

@mkurz I don’t think it needs to be backported to 1.8.x since there is no arch variable in that branch.

@mkurz
Copy link
Member

mkurz commented Jan 27, 2023

@julienrf hmm.. are you sure? See https://github.com/sbt/sbt/blob/1.8.x/sbt#L174

@julienrf
Copy link
Contributor

Ahah indeed, I was not up to date. I’ve created #7144 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants