Skip to content

[1.8.x] Prepare aarch64 support for sbtn binary #7108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

[1.8.x] Prepare aarch64 support for sbtn binary #7108

merged 2 commits into from
Jan 3, 2023

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jan 2, 2023 •
edited
Loading

In https://github.com/mkurz/sbtn-dist/commits/aarch64-support I am setting up a GitHub actions job to build a sbtn binary for Linux aarch64. To make this happen, the changes in this PR are necessary. I am almost done, binary can be downloaded here already: https://github.com/mkurz/sbtn-dist/actions/runs/3825258120

@lightbend-cla-validator
Copy link

Hi @mkurz,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

https://www.lightbend.com/contribute/cla

@mkurz mkurz changed the title Prepare aarch64 support for sbtn binary [1.8.x] Prepare aarch64 support for sbtn binary Jan 2, 2023
mkurz
mkurz commented Jan 2, 2023
View reviewed changes
build.sbt
),
) ++ (if (isLinux && isArmArchitecture)
Seq("-H:PageSize=65536") // Make sure binary runs on kernels with page size set to 4k, 16 and 64k
else Nil),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to set the page size to 64k for aarch64 binaries to make sure it runs on all kind of kernels.
I did lots of research, collected here: coursier/coursier#2636 (comment)

scala-ci already merged the same fix: VirtusLab/scala-cli#1726
coursier should follow soon: coursier/coursier#2641

@mkurz
Copy link
Member Author

mkurz commented Jan 2, 2023

@eed3si9n If you could take a look, that would be nice. More pull requests are coming afterwards. (Also, I just signed the CLA). Thanks!

@mkurz mkurz mentioned this pull request Jan 3, 2023
Merged
eed3si9n
eed3si9n approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If possible, could you target the default branch (currently 1.9.x branch), and backport next time?

@eed3si9n eed3si9n merged commit e529c9a into sbt:1.8.x Jan 3, 2023
@mkurz mkurz deleted the sbtn-aarch64 branch January 3, 2023 09:06
@mkurz mkurz mentioned this pull request Jan 3, 2023
Closed
@mkurz
Copy link
Member Author

mkurz commented Jan 3, 2023

If possible, could you target the default branch (currently 1.9.x branch), and backport next time?

Sure 👍

@mkurz mkurz mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkurz @lightbend-cla-validator @eed3si9n