Skip to content

feat: implement BSP's environment requests #6858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 12, 2022
Merged

feat: implement BSP's environment requests #6858

merged 5 commits into from
Apr 12, 2022

Conversation

kpodsiad
Copy link
Contributor

Implementation of https://build-server-protocol.github.io/docs/extensions/jvm.html.

Could you guide me on what will be the best way to test these endpoints?

kpodsiad
kpodsiad commented Mar 31, 2022
View reviewed changes
Copy link
Contributor Author

@kpodsiad kpodsiad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for all of these questions, I'm still pretty new to the sbt's Tasks and scoping and other stuff - that's why there is a lot of code repetition. I'll appreciate suggestions of any kind on how to refactor common parts.

@kpodsiad
Copy link
Contributor Author

kpodsiad commented Apr 5, 2022

@adpi2 are there somewhere BSP's tests? I searched for them but I found nothing.

@adpi2
Copy link
Member

adpi2 commented Apr 5, 2022

@adpi2 are there somewhere BSP's tests? I searched for them but I found nothing.

Yes we have some tests in the BuildServerTest class. They run on the build defined here that you can edit to add some environment variables.

To run the tests:

sbt:sbtRoot> serverTestProj/testOnly testpkg.BuildServerTest

@kpodsiad kpodsiad force-pushed the feat/bsp-env-request branch from a89bcca to 7735513 Compare April 6, 2022 07:09
@kpodsiad
Copy link
Contributor Author

kpodsiad commented Apr 6, 2022

2 tests have exceeded the timeout, but it doesn't seem like it's caused by my changes, at least not directly.
I rebased my changes to rerun CI actions.

@kpodsiad
Copy link
Contributor Author

kpodsiad commented Apr 6, 2022

@adpi2 do you have an idea why some actions are never-ending/seem to have deadlock? I checked my changes and I didn't find anything suspicious.

adpi2
adpi2 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thanks for cleaning the code duplication.

Those changes are not breaking the forward compatibility. Could you back-port them to 1.7.x branch?

@kpodsiad
Copy link
Contributor Author

Those changes are not breaking the forward compatibility. Could you back-port them to 1.7.x branch?

Should I create another PR that targets 1.7.x or should I change the target in this one?

@adpi2
Copy link
Member

adpi2 commented Apr 12, 2022

Yeah another PR would be good.

@kpodsiad kpodsiad mentioned this pull request Apr 12, 2022
Merged
@adpi2 adpi2 merged commit dbdd6c2 into sbt:develop Apr 12, 2022
@kpodsiad kpodsiad mentioned this pull request Apr 16, 2022
Merged
@eed3si9n eed3si9n added this to the 1.7.0 milestone Apr 18, 2022
@kpodsiad kpodsiad mentioned this pull request Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adpi2 adpi2 adpi2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kpodsiad @adpi2 @eed3si9n