includePluginResolvers should work for coursier resolutions #6849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Mar 23, 2022
| if (isSbtPlugin) sbtResolvers.value ++ extRes | ||
| else extRes | ||
| } | ||
| val result0 = fullResolvers.value.filterNot(_ == projectResolver.value) |
There was a problem hiding this comment.
sbt/main/src/main/scala/sbt/Defaults.scala
Lines 2965 to 2986 in ccc6cf6
The filter is not strictly mandatory as https://github.com/coursier/sbt-coursier/blob/fb19697c573489d1ddbd6c3afd9d8609a70c4fec/modules/lm-coursier/src/main/scala/lmcoursier/internal/Resolvers.scala#L114-L115 seems to ignore projectResolver, but I thought it was better not to change the behavior of csrResolvers, particularly if this is backported to 1.6.x.
5545516 to
fb479ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #5094 didn't really address #5070 as the coursier behavior was not updated (only ivy which relies on
fullResolvers).I haven't found any active usage of
includePluginResolversin open-source, but gitter-badger/bqtest@aa75c2b seems to confirm it does not work as expected.