Skip to content

Improve log for not found remote cache artifact #6824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2022
Merged

Improve log for not found remote cache artifact #6824

merged 1 commit into from
Feb 27, 2022

Conversation

gontard
Copy link
Contributor

@gontard gontard commented Feb 25, 2022 •
edited
Loading

When a remote cache artifact isn't found, print a more specific log with the project and the classifier:

-remote cache not found for 0.0.0-7c40144bd1c774e6
+remote cache artifact not found for org.gontard:sbt-test:0.0.0-7c40144bd1c774e6 Some(cached-compile)

It also aligned with other logs:

remote cache artifact extracted for org.gontard:sbt-test:0.0.0-7c40144bd1c774e6 Some(cached-compile)

@gontard
Improve log for not found remote cache artifact
d25dfd0 
Before
remote cache not found for 0.0.0-7c40144bd1c774e6

After
remote cache artifact not found for org.gontard:sbt-test:0.0.0-7c40144bd1c774e6 Some(cached-compile)
eed3si9n
eed3si9n approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit ba5f752 into sbt:develop Feb 27, 2022
@adpi2 adpi2 mentioned this pull request Mar 8, 2022
Merged
@gontard
Copy link
Contributor Author

gontard commented May 18, 2022

Hello @eed3si9n
i saw that this one was not part of https://github.com/sbt/sbt/releases/tag/v1.7.0-M2. Would it possible to include it in the next release? 🙏 (It's not a big change but it would be very convenient for troubleshooting)

@gontard gontard mentioned this pull request Sep 30, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
backport candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gontard @eed3si9n