[1.6.x] Fixes fake position handling, take 2 #6730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt#6720 Ref sbt#5994 Problem ------- Sometimes the compiler returns a fake position such as `<macro>`. This causes this causes InvalidPathException on Windows if we try to convert it into NIO path. Solution -------- Looks for less-than sign in the VirtualFileRef and skip those. Since BSP requires the diagnostic info to be associated with files, we probably can't do much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6720
Ref #5994
Problem
Sometimes the compiler returns a fake position such as
<macro>.This causes this causes InvalidPathException on Windows if we try
to convert it into NIO path.
Solution
Looks for less-than sign in the VirtualFileRef and skip those.
Since BSP requires the diagnostic info to be associated with
files, we probably can't do much.