Skip to content

[BSP] Handle base sources #6701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2021
Merged

[BSP] Handle base sources #6701

merged 2 commits into from
Oct 29, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Oct 29, 2021 •
edited
Loading

Add support for base sources in BSP implementation.

This is working well in Metals:
image

However IntelliJ ignores those base source files, probably because it expects all source files to be in a source folder.

@adpi2 adpi2 force-pushed the bsp-sources-in-base branch from 1cbe7e4 to d953028 Compare October 29, 2021 13:39
adpi2 added 2 commits October 29, 2021 15:40
@adpi2
[BSP] Support base source files
e64c71d
@adpi2
[BSP] remove duplicated sources in sbt build target
75d3bf2 
Also remove the base directory (`./project/`) from the list of source directories
@adpi2 adpi2 force-pushed the bsp-sources-in-base branch from d953028 to 75d3bf2 Compare October 29, 2021 13:40
@adpi2 adpi2 marked this pull request as ready for review October 29, 2021 13:43
@adpi2 adpi2 requested a review from eed3si9n October 29, 2021 14:28
@eed3si9n eed3si9n merged commit 530505d into sbt:develop Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpi2 @eed3si9n