Skip to content

[BSP] Respond error after random failure when compiling #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2021
Merged

[BSP] Respond error after random failure when compiling #6565

merged 5 commits into from
Jun 25, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Jun 24, 2021 •
edited
Loading

Fixes #6562 reported by @samuelClarencTeads

  • When a BSP task fails we send an error response that contains the error message.
  • When the bspCompileItem catches an exception: if it is a CompileFailed we respond with a StatusCode.Error result, if it is an InterruptedException we respond with a StatusCode.Cancelled result, otherwise we send an error response.
  • The old error response with a -33000 code and no message is made silent if another response has already been sent.
  • Add a server test to check the error message on a custom compilation failure

@adpi2 adpi2 force-pushed the fix-6562 branch 2 times, most recently from 2468985 to 3feed34 Compare June 24, 2021 16:09
@bjaglin bjaglin mentioned this pull request Jun 24, 2021
Closed
@adpi2 adpi2 marked this pull request as ready for review June 25, 2021 09:08
@adpi2 adpi2 requested a review from eed3si9n June 25, 2021 09:16
@adpi2 adpi2 mentioned this pull request Jun 25, 2021
Merged
eed3si9n
eed3si9n approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adpi2!

@eed3si9n eed3si9n merged commit e4231ac into sbt:develop Jun 25, 2021
@eed3si9n eed3si9n added this to the 1.5.5 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.5
Development

Successfully merging this pull request may close these issues.

[BSP] - Scalafix compilation failure
2 participants
@adpi2 @eed3si9n