Skip to content

Conversation

sebastian-alfers
Copy link
Contributor

Preserved the carriage return if followed by a line feed.

@sebastian-alfers
Copy link
Contributor Author

sebastian-alfers commented Jun 20, 2021

@eed3si9n As mentioned, I run the following without metals locally:

$ sbt
...
sbt:sbtRoot> project utilLogging
...
sbt:Util Logging> testOnly *.ProgressStateSpec

And I get this:

[info] Formatting 1 Scala sources...
[info] Formatting 1 Scala sources...
[error] scalafmt version 2.3.2 classpath is corrupted: /Users/sebalf/dev/sebastian-alfers/sbt/.scalafmt.conf

However when I apply the following it works:

-addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.3.0")
+addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.2")

I can create a separate PR if you think it makes sense but wanted to keep it out of this PR.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastian-alfers
Copy link
Contributor Author

Not sure if the failing builds are related to my change.

@eed3si9n
Copy link
Member

@sebastian-alfers I think it is tangentially related in a sense that adding additional test has uncovered some weird race condition / initialization issue that was previously not noticed. I have a fix for that, which I tested first on top of this PR to make sure it would fix both - #6557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants