Fixes spurious "@nowarn annotation does not suppress any warnings" in old style sbt plugins with sbtPlugin := true
#6517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
May 21, 2021
|
@Nirvikalpa108 Thanks for the contribution! |
Fixes sbt#6430. What is the problem? As detailed in sbt#6430, the @nowarn annotation was not suppressing warnings, even after the first attempt to fix this in PR#6431. This first PR fixed the problem for projects using enablePlugins(SbtPlugin), but not for those using sbtPlugin := true. Why is this a valuable problem to solve? The annotation was not working as users would expect. What is this solution? I have moved the scalacOptions change from SbtPlugin.projectSettings to the scalacOptions in the JvmPlugin settings. Has this been tested? Yes, a test has been added. Also, this branch was tested successfully on the twinagle repo (soundcloud/twinagle#224).
eed3si9n
approved these changes
May 21, 2021
sbtPlugin := true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
As detailed in #6430, the @nowarn annotation was not suppressing warnings, even after the first attempt to fix this in PR#6431. This first PR fixed the problem for projects using
enablePlugins(SbtPlugin), but not for those usingsbtPlugin := true.Why is this a valuable problem to solve?
The annotation was not working as users would expect.
What is the solution?
I have moved the scalacOptions change from
SbtPlugin.projectSettingsto the scalacOptions in theJvmPluginsettings.Has this been tested?
Yes, a test has been added. Also, this branch was tested successfully on the twinagle repo (soundcloud/twinagle#224).
Fixes #6430.