Fix tab completion perf regression #6214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2020
|
Tried SBT 1.4.6 and now it's much quicker. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit edf43a4.
This fixes performance regression of tab completion observed in #6204
As originally mentioned by @eatkins, JLine 3 will automatically append a white space character (
" ") to the completioncandidate. In practice it doesn't really seem to bother the shell if we put in
"++2.11.12"or"++2.11.12 "with the whitespace so I think it's ok to do so for now.Perhaps in the future the parser could return a signal indicating
++2.11.12and then End-of-Line or Whitespace-and-more?