Skip to content

Parse network client arguments early #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2020
Merged

Parse network client arguments early #6019

merged 1 commit into from
Oct 24, 2020

Conversation

eatkins
Copy link
Contributor

@eatkins eatkins commented Oct 24, 2020

With sbtn, the system properties are passed in as regular command
arguments. We need to parse them before we call Terminal.withStreams or
else system properties like -Dsbt.color=false are ignored.

@eatkins
Parse network client arguments early
69510b1 
With sbtn, the system properties are passed in as regular command
arguments. We need to parse them before we call Terminal.withStreams or
else system properties like -Dsbt.color=false are ignored.
@eed3si9n eed3si9n merged commit 1692b93 into sbt:develop Oct 24, 2020
@eatkins eatkins deleted the client-properties branch October 24, 2020 22:57
@eed3si9n eed3si9n added the area/sbtn thin client issues label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
area/sbtn thin client issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eatkins @eed3si9n