Skip to content

Fix #5994: sourceMappers handles fake positions #6008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2020
Merged

Fix #5994: sourceMappers handles fake positions #6008

merged 3 commits into from
Oct 26, 2020

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Oct 22, 2020 •
edited
Loading

Fixes #5994

Sometimes the compiler reports errors on a file that does not really exist: for instance pos.sourcePath can contain "<macro>". In such case the sourceMappers should not fail when converting the pos.sourcePath to absolute path.

  • Fixed Defaults.toAbsoluteSourceMapper
  • Added scripted tests on the sourceMappers
  • Run the reporter:source-mapper scripted test on windows

@adpi2 adpi2 marked this pull request as draft October 22, 2020 10:44
@adpi2 adpi2 marked this pull request as ready for review October 22, 2020 12:04
@adpi2 adpi2 requested a review from eed3si9n October 22, 2020 12:05
eed3si9n
eed3si9n reviewed Oct 23, 2020
View reviewed changes
@adpi2 adpi2 requested a review from eed3si9n October 26, 2020 07:49
@eed3si9n eed3si9n merged commit cf78d18 into sbt:develop Oct 26, 2020
@eed3si9n eed3si9n mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression on Windows during migration from 1.4.0 to 1.4.1
2 participants
@adpi2 @eed3si9n