Fix line reader for jEdit #5946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user reported that no prompt was displayed when they used sbt from the jEdit console. The reason no prompt was displayed was because System.console was null which caused the ConsoleChannel to be initialized with its prompt set to NoPrompt. I don't remember why it was doing this but this bug seems worse than whatever it was trying to address.
On my computer with jEdit, input is not read because the console input stream was overridden to be a blocking input stream that never returned input. While debugging the server test hangs, I added some logic to prevent us from trying to read from System.in when System.console == null but I now realize that was a mistake because of situations like ides or editors launching an sbt shell.
eed3si9n
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5936
There were a few issues with line reading with jEdit. One was the console prompt was not displayed because the console prompt was disabled when
System.console == null. The other was that we in some cases did not read any input from System.in whenSystem.console == null. To fix the latter, I needed to add some explicit handling for dumb terminals. After these changes, the sbt shell worked fine in the jEdit console on my computer.