Skip to content

Add settings allowing AOSP style #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2020
Merged

Add settings allowing AOSP style #100

merged 1 commit into from
Aug 17, 2020

Conversation

joriscode
Copy link
Contributor

This PR adds opt-in setting for the AOSP style supported by https://github.com/google/google-java-format/blob/master/core/src/main/java/com/google/googlejavaformat/java/JavaFormatterOptions.java.

Please let me know what you think

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

1 similar comment
@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@joriscode
Copy link
Contributor Author

I'll fix the "typesafe-cla-validator" issue with next commit

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

1 similar comment
@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@joriscode
Copy link
Contributor Author

@nigredo-tori Hi, new changes :)

@nigredo-tori
Copy link

@joriscode, LGTM 👍

@joriscode joriscode force-pushed the jbe/add_aosp_style_settings branch from 14c039c to 9f9a628 Compare August 11, 2020 09:15
@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@joriscode joriscode force-pushed the jbe/add_aosp_style_settings branch from 9f9a628 to 8575ce2 Compare August 11, 2020 09:20
@joriscode
Copy link
Contributor Author

@nigredo-tori CLA fixed and history rebased & squashed. Thank you for the reviews. PR is now ready for merge

pvlugter
pvlugter approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pvlugter pvlugter merged commit b0b907f into sbt:master Aug 17, 2020
@pvlugter
Copy link
Member

And released as version 0.6.0

@joriscode joriscode deleted the jbe/add_aosp_style_settings branch August 18, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvlugter pvlugter pvlugter approved these changes

+1 more reviewer

@nigredo-tori nigredo-tori nigredo-tori left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joriscode @lightbend-cla-validator @nigredo-tori @pvlugter