Skip to content

Add javafmtOnCompile setting #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

Add javafmtOnCompile setting #70

merged 2 commits into from
Mar 3, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Mar 2, 2020 •
edited
Loading

Users could disable AutomateJavaFormatterPlugin however i think it's not very intuitive; lmtk what do you think about adding this setting.

With this setting we have some parity with scalafmtOnCompile

@regadas regadas force-pushed the feature/add-on-compile-setting branch from 43e4fe6 to f0e66e2 Compare March 2, 2020 03:47
@ennru ennru mentioned this pull request Mar 2, 2020
Closed
@ennru
Copy link
Contributor

ennru commented Mar 2, 2020

Did you notice the discussion in #68?

@mkurz
Copy link
Member

mkurz commented Mar 2, 2020

I am totally OK using this pull request instead of mine (#68).
However I think it is still a good idea to disable javafmtOnCompile by default. First to keep it aligned with scalafmt, which also disables format on compile by default, second I think it may be too intrusive: E.g. if you add the plugin to a project and have uncommitted changes in java files, the formatter kicks in and re-formats everything, and suddenly you end up not knowing what were the changes you did and what are the changes javafmt did. That happend to me once.
BTW: I did not review the pull request.

@regadas
Copy link
Contributor Author

regadas commented Mar 2, 2020

Apologies! I did miss #68 There were a lot of open PR and I didn't see this one in the middle of them.

Yeah I also agree that formatting on compile should be disabled by default; I only kept it as is right now to make the transition smooth for the javafmtOnCompile setting. My plan was: release a new version with this now and in the next version break the current behaviour. We can however do it in one blow ¯_(ツ)_/¯ . lmwt.

@ennru ennru changed the title Add javafmOnCompile setting Add javafmtOnCompile setting Mar 2, 2020
@ennru
Copy link
Contributor

ennru commented Mar 2, 2020

Yes, I like the two-step idea. I'll review this and release 0.5.1 after merging.

ennru
ennru approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 23c4559 into sbt:master Mar 3, 2020
@mkurz
Copy link
Member

mkurz commented Mar 4, 2020

@ennru Any ETA for 0.5.1?

@regadas regadas deleted the feature/add-on-compile-setting branch April 21, 2020 01:11
@armanbilge armanbilge mentioned this pull request Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regadas @ennru @mkurz