Try resolve sbt plugin from valid Maven pattern #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2022
julienrf
reviewed
Dec 22, 2022
|
@adpi2 Overall looks good to me as well. As I understood the conversation on Slack, the magic is that POM's |
d87a1ae to
cad671f
Compare
sbt plugins were published to an invalid path with regard to Maven's specifictation. As of sbt 1.9 we produce two POMs, a deprecated one and a new one, that is valid with regard to Maven resolution. When resolving, we first try to resolve the new valid POM and we fallback to the invalid one if needed. In the new POM format, we append the sbt cross-version to all artifactIds of sbt plugins. This is because we want Maven to be able to resolve the plugin and all its dependencies. When parsing it, we remove the cross-version suffix so that the result of parsing the valid POM format is exactly the same as parsing the deprecated POM format. Hence conflict resolution happens as intended. More details can be found at sbt/sbt#7096
cad671f to
5a0e9b2
Compare
|
I added a few more comments, and I rewrote the commit message. Also I suggest we wait a bit before merging, until we agree on the implementation in coursier/coursier#2633. |
julienrf
approved these changes
Dec 29, 2022
|
Coursier is now ready to resolve the new Maven pattern of sbt plugins:
@eed3si9n If you agree, I need your ✔️ to merge this PR. |
eed3si9n
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of sbt/sbt#7096 whose goal is to fix sbt/sbt#3410 in a smooth way. For a full description please read sbt/sbt#7096.