Fixes match error when using withDottyCompat #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sbt/sbt#6210 scodec-bits is published with pvp versionScheme (nice), this means that we should just evaluate the version portion for pvp-ness, but I was using `guessSecondSegment` that checks for Scala suffix. That's mistake 1. `guessSecondSegment` assumes that the Scala suffix uses the given ScalaModuleInfo, but with 2.13-3 sandwich we can't assume this. In the reported case, Scala module is 3.0.0-M3 but scodec-bits uses 2.13. So that's mistake 2. This attempts to correct both the mistakes. 1. Instead of `guessSecondSegment`, this adds a simpler `evalPvp` function. 2. `guessSecondSegment` just looks for `_2.` or `_3` and ignores the Scala module.
|
Locally confirmed that this will fix the actual bug: |
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
Dec 20, 2020
Follow-up on sbt#352
Merged
eed3si9n
added a commit
to eed3si9n/librarymanagement
that referenced
this pull request
Dec 20, 2020
Follow-up on sbt#352
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sbt/sbt#6210
scodec-bits is published with pvp
versionScheme(nice), this means that we should just evaluate the version portion for pvp-ness, but I was usingguessSecondSegmentthat checks for Scala suffix. That's mistake 1.guessSecondSegmentassumes that the Scala suffix uses the given ScalaModuleInfo, but with 2.13-3 sandwich we can't assume this. In the reported case, Scala module is 3.0.0-M3 but scodec-bits uses 2.13. So that's mistake 2.This attempts to correct both the mistakes.
guessSecondSegment, this adds a simplerevalPvpfunction.guessSecondSegmentjust looks for_2.or_3and ignores the Scala module.