Force the type of an annotation's typeSymbol before checking isStatic #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 2.13, `isStatic` is implemented by `isNonBottomSubClass(StaticAnnotationClass)` which forces the annotation symbol's type. In 2.13, Java annotations are identified by flags. This check doesn't force the info, and the flags are missing if the info is still a `ClassfileLoader`. This leads to spurious API changes (annotation goes missing) if the depending if the info is already forced or not. A fix for this will be in 2.13.7, but we should still work around it in Zinc to make sure zinc works correctly on 2.13.0-6.
retronym
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before 2.13,
isStaticis implemented byisNonBottomSubClass(StaticAnnotationClass)which forces the annotation symbol's type.
In 2.13, Java annotations are identified by flags. This check doesn't
force the info, and the flags are missing if the info is still a
ClassfileLoader.This leads to spurious API changes (annotation goes missing) if the
depending if the info is already forced or not.
A fix for this will be in 2.13.7, but we should still work around it
in Zinc to make sure it works correctly on 2.13.0-6.
Fixes #998