Don't use autoBoot / filterLibrary for 2.13 and 3 #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Jan 23, 2024
internal/zinc-compile-core/src/main/java/xsbti/compile/ClasspathOptionsUtil.java
Outdated
Show resolved
Hide resolved
eed3si9n
reviewed
Jan 23, 2024
internal/zinc-compile-core/src/main/java/xsbti/compile/ClasspathOptionsUtil.java
Outdated
Show resolved
Hide resolved
Passing `-bootclasspath /path/to/scala-library.jar` to the Scala compiler is only done for historical reasons. Putting the Scala library on the ordinary classspath is equivalent. This commit adds a `noboot` factory for ClasspathOptions which doesn't use `-bootclasspath` for Scala 2.13 and Scala 3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
-bootclasspath /path/to/scala-library.jarto the Scala compiler is only done for historical reasons. Putting the Scala library on the ordinary classspath is equivalent.This commit adds a
nobootfactory for ClasspathOptions which doesn't use-bootclasspathfor Scala 2.13 and Scala 3.This change was made in the context of SIP-51, unfreeze the Scala library / sbt/sbt#7480, but it's just a cleanup and not actually required.