fix: Improve thread management to prevent unwanted terminal output on exit #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae6efb to
e89ac85
Compare
- Replace thread::scope with detached threads to improve shutdown sequence - Add polling loop in main thread to monitor termination status - Change user input thread to use infinite loop pattern - Implement error logging instead of error propagation The terminal was being filled with unwanted characters on exit because the user input thread was terminating before raw mode could be disabled. Input events like mouse movements that accumulated in the buffer between the user input thread termination and raw mode disabling were being output to the terminal after raw mode was disabled. By changing to detached threads that terminate simultaneously with the main thread, we ensure that raw mode is disabled before the user input thread terminates, resolving the issue.
- Replace AtomicBool flags with channels for thread termination - Simplify inter-thread communication during shutdown - Implement consistent error handling across worker threads - Remove unnecessary error propagation to main thread - Make worker loops more straightforward with infinite loops This change improves the reliability and clarity of the application's shutdown process by using explicit signaling through channels rather than polling termination flags. Worker threads now log errors locally and trigger shutdown signals rather than propagating errors upward.
e89ac85 to
316b91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace thread joins with asynchronous execution to ensure proper event processing before raw mode cleanup. This prevents unwanted terminal output during shutdown. Add error logging for worker threads.