xim context creation #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First: Reading the code in its current state, I see no reason to include it in libgwater . TL;DR: it doesn’t belong here, IMO, so I will close this MR Now, thanks for the effort, and I still have a review comment: when you contribute to a project, please, follow the style that is already in place. Here, specifically, no “long lines wrapping” and the |
|
ok, that method wrapped two times on my editor, thought it was harmless, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just creates an IM context to be used later, this shouldn't affect anything aside from requiring
#include <xcb-imdkit/imclient.h>
before including libgwater_xcb.h, is this desirable? or I missed something the way the headers are handled?
the context is only put to use when calling xcb_xim_open()