-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add new command for new path #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
Please update the docs too.
bin/shipit
Outdated
@@ -45,6 +45,7 @@ usage() { | |||
echo " console shell, ssh Open an SSH session on the remote host" | |||
echo " exec <cmd> run Execute <cmd> on the remote host" | |||
echo " copy <file> cp Copy <files> to the remote host" | |||
echo " --config -c Path config file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“Config file path (default: .shipit)”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s actually a file name, not a path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks to you for the fantastic script. I use it every day 👍
Excuse my English, is that correct now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ;-) Config file path → Config file name.
bin/shipit
Outdated
@@ -239,6 +240,7 @@ done | |||
arg=$1; shift | |||
if [ -n "$arg" ]; then | |||
case $arg in | |||
-c|--config) CONFIG_NAME="$@";; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it should be in the options loop above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand where you mean. Where did I put it now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here:
Lines 231 to 236 in 5e6e2ee
# Options | |
for arg in "$@"; do | |
case "$arg" in | |
-v|--verbose) verbose; shift ;; | |
esac | |
done |
I can't get it to work as an option. |
I think you need to call |
Already working! |
Awesome, thanks! |
To you for guiding me and teaching me. Fantastic script! |
No description provided.