Skip to content

Conversation

tanrax
Copy link
Contributor

@tanrax tanrax commented Nov 5, 2017

No description provided.

Copy link
Owner

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Please update the docs too.

bin/shipit Outdated
@@ -45,6 +45,7 @@ usage() {
echo " console shell, ssh Open an SSH session on the remote host"
echo " exec <cmd> run Execute <cmd> on the remote host"
echo " copy <file> cp Copy <files> to the remote host"
echo " --config -c Path config file"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Config file path (default: .shipit)”.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s actually a file name, not a path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks to you for the fantastic script. I use it every day 👍
Excuse my English, is that correct now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ;-) Config file path → Config file name.

bin/shipit Outdated
@@ -239,6 +240,7 @@ done
arg=$1; shift
if [ -n "$arg" ]; then
case $arg in
-c|--config) CONFIG_NAME="$@";;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should be in the options loop above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where you mean. Where did I put it now?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here:

shipit/bin/shipit

Lines 231 to 236 in 5e6e2ee

# Options
for arg in "$@"; do
case "$arg" in
-v|--verbose) verbose; shift ;;
esac
done

@tanrax
Copy link
Contributor Author

tanrax commented Nov 6, 2017

I can't get it to work as an option.

@sapegin
Copy link
Owner

sapegin commented Nov 6, 2017

I think you need to call shift twice: to remove --config and to remove the value.

@tanrax
Copy link
Contributor Author

tanrax commented Nov 6, 2017

Already working!

@sapegin sapegin merged commit df6f9e7 into sapegin:master Nov 7, 2017
@sapegin
Copy link
Owner

sapegin commented Nov 7, 2017

Awesome, thanks!

@tanrax
Copy link
Contributor Author

tanrax commented Nov 7, 2017

To you for guiding me and teaching me. Fantastic script!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants